WIP: [ci] include lightgbm's dependencies in linting job #5746
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This proved to be more difficult than I thought it would be. I'm going to close this to focus on other things. Sorry for the noise. |
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3756
Contributes to #3867.
The
lintCI job runsmypy, a static type-checker for Python.The code in
python-package/compat.pyhandles optional imports by creating placeholder empty classes and functions. For example, like this:LightGBM/python-package/lightgbm/compat.py
Line 25 in 39ed8ea
Since many of
lightgbm's dependencies (likepandasandmatplotlib) are not currently installed during thelintCI job, it's those placeholder definitions thatmypychecks. And the presence of# type: ignorecomments on many of them short-circuits the type-checking process.As a result, the
lintjob is currently not able to detect issues like "pandas Series do not have attribute.xyz".This PR proposes installing all of those dependencies in the
lintCI job, to improve the ability of CI to catch such incompatibilities (at least with the latest version of all installed dependencies).